[llvm] [GlobalISel] Combine G_ZEXT of undef -> 0 (PR #113764)

[Amara Emerson via llvm-commits]

Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/113764 at github.com>


aemerson wrote:

> Exploding PRs based on misunderstanding is a poor sport.

Believe me when I say none of us enjoy this any more than you do. Us having to argue for why a function called `replaceInstWithConstant` should do as it says it will do is frankly tiring. We understand your points but our opinion is that it's the wrong choice in terms of good engineering practices.

> You are ignoring my comment. No surprise.

I don't know who exactly this was directed to but I don't believe anyone was ignoring anything. If you continue to make these sorts of comments I will completely stop engaging in any reviews from you.

https://github.com/llvm/llvm-project/pull/113764