[compiler-rt] [rtsan][NFC] Remove some unneeded headers, make guards more obvious (PR #114911)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 4 18:01:38 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Chris Apple (cjappl)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/114911.diff
2 Files Affected:
- (modified) compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp (+2-4)
- (modified) compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp (-5)
``````````diff
diff --git a/compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp b/compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
index b02be0b3cb51be..55241972167191 100644
--- a/compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
+++ b/compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
@@ -15,12 +15,10 @@
#include "interception/interception.h"
#include "sanitizer_common/sanitizer_allocator_dlsym.h"
-#include "sanitizer_common/sanitizer_allocator_internal.h"
#include "sanitizer_common/sanitizer_platform_interceptors.h"
#include "interception/interception.h"
#include "rtsan/rtsan.h"
-#include "rtsan/rtsan_context.h"
#if SANITIZER_APPLE
@@ -33,11 +31,11 @@ extern "C" {
typedef int32_t OSSpinLock;
void OSSpinLockLock(volatile OSSpinLock *__lock);
}
-#endif
+#endif // TARGET_OS_MAC
#include <libkern/OSAtomic.h>
#include <os/lock.h>
-#endif
+#endif // SANITIZER_APPLE
#if SANITIZER_INTERCEPT_MEMALIGN || SANITIZER_INTERCEPT_PVALLOC
#include <malloc.h>
diff --git a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
index 8ed933fad51b11..9ddaa5d5eb590b 100644
--- a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
+++ b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
@@ -28,11 +28,6 @@
#include <malloc.h>
#endif
-#include <atomic>
-#include <chrono>
-#include <string>
-#include <thread>
-
#include <fcntl.h>
#include <pthread.h>
#include <stdio.h>
``````````
</details>
https://github.com/llvm/llvm-project/pull/114911
More information about the llvm-commits
mailing list