[llvm] [DirectX] Flatten arrays (PR #114332)
Farzon Lotfi via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 4 10:23:32 PST 2024
================
@@ -1,4 +1,5 @@
-; RUN: opt -S -passes='dxil-data-scalarization,function(scalarizer<load-store>),dxil-op-lower' -mtriple=dxil-pc-shadermodel6.3-library %s | FileCheck %s
+; RUN: opt -S -passes='dxil-data-scalarization,function(scalarizer<load-store>),dxil-op-lower' -mtriple=dxil-pc-shadermodel6.3-library %s | FileCheck %s -check-prefix DATACHECK
+; RUN: opt -S -passes='dxil-data-scalarization,dxil-flatten-arrays,function(scalarizer<load-store>),dxil-op-lower' -mtriple=dxil-pc-shadermodel6.3-library %s | FileCheck %s
----------------
farzonl wrote:
The problem is two fold I want this to be a scalarizer test case, but we are using the `llc` run line. `llc` was important to find bugs were my passes could have created invalid llvmir for later passes. Dropping a flatten-arrays pass also means dropping the llc run line. So I saw three paths forward.
1. Drop llc and make this a scalarizer only test. Downside if later passes break things the CI won't catch it.
2. Drop the scalarizer specifics from the test. Downside is we don't have scalarizer only tests
3. Do what I'm currently doing to maintain both llc and data scalarization specifics in one test.
https://github.com/llvm/llvm-project/pull/114332
More information about the llvm-commits
mailing list