[llvm] [llvm][llvm-lit] Hide --use-unique-output-file-name from --help (PR #114812)

David Spickett via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 07:29:33 PST 2024


https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/114812

I was too hasty landing an option whose only known use at this time is LLVM's own CI.

We may be able to remove it before the next branch that would be the next llvm-lit release outside of llvm, but the timing may not work out.

So I am hiding the option in case that were to happen.

>From e8a9e14d11a37130f99a0336275aab2f86cb695a Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Tue, 29 Oct 2024 15:38:12 +0000
Subject: [PATCH] [llvm][llvm-lit] Hide --use-unique-output-file-name from
 --help

I was too hasty landing an option whose only known use
at this time is LLVM's own CI.

We may be able to remove it before the next branch that would
be the next llvm-lit release outside of llvm, but the timing
may not work out.

So I am hiding the option in case that were to happen.
---
 llvm/utils/lit/lit/cl_arguments.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/llvm/utils/lit/lit/cl_arguments.py b/llvm/utils/lit/lit/cl_arguments.py
index 3e5488f388ccfa..a401c9a09e081b 100644
--- a/llvm/utils/lit/lit/cl_arguments.py
+++ b/llvm/utils/lit/lit/cl_arguments.py
@@ -175,12 +175,15 @@ def parse_args():
         type=lit.reports.TimeTraceReport,
         help="Write Chrome tracing compatible JSON to the specified file",
     )
+    # This option only exists for the benefit of LLVM's Buildkite CI pipelines.
+    # As soon as it is not needed, it should be removed. Its help text would be:
+    # When enabled, lit will add a unique element to the output file name,
+    # before the extension. For example "results.xml" will become
+    # "results.<something>.xml". The "<something>" is not ordered in any
+    # way and is chosen so that existing files are not overwritten. [Default: Off]
     execution_group.add_argument(
         "--use-unique-output-file-name",
-        help="When enabled, lit will add a unique element to the output file name, "
-        'before the extension. For example "results.xml" will become '
-        '"results.<something>.xml". The "<something>" is not ordered in any '
-        "way and is chosen so that existing files are not overwritten. [Default: Off]",
+        help=argparse.SUPPRESS,
         action="store_true",
     )
     execution_group.add_argument(



More information about the llvm-commits mailing list