[llvm] [llvm-symbolizer] Improve error messages for filter symbolization failure (PR #114649)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 4 00:25:39 PST 2024
================
@@ -698,6 +695,24 @@ void MarkupFilter::reportLocation(StringRef::iterator Loc) const {
errs() << '\n';
}
+void MarkupFilter::symbolizeFailure(const MarkupNode &Node, const Module *Mod,
+ Error SymbolizeError) {
+ if (Mod) {
----------------
jh7370 wrote:
In the three call sites you've modified, the `Mod` must always be present, so this feels like an unnecessary check?
https://github.com/llvm/llvm-project/pull/114649
More information about the llvm-commits
mailing list