[llvm] 3fb4b6f - [ORC] Rename "TargetJD" parameter of redirect method to just "JD". NFC.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 21:45:12 PDT 2024


Author: Lang Hames
Date: 2024-11-02T15:44:21+11:00
New Revision: 3fb4b6f0521c923fd3b925106b12847ccf40864c

URL: https://github.com/llvm/llvm-project/commit/3fb4b6f0521c923fd3b925106b12847ccf40864c
DIFF: https://github.com/llvm/llvm-project/commit/3fb4b6f0521c923fd3b925106b12847ccf40864c.diff

LOG: [ORC] Rename "TargetJD" parameter of redirect method to just "JD". NFC.

In JITLinkRedirectableSymbolManager::redirect we no longer need to disambiguate
between the JD for the redirectable symbols and the one for the corresponding
stubs (they're the same as of 529c091381a). Renaming it brings the parameter
name into line with the one used in the base class's redirect method.

Added: 
    

Modified: 
    llvm/include/llvm/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.h
    llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.h b/llvm/include/llvm/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.h
index be92f5083969f7..9c6daef9283348 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.h
@@ -42,7 +42,7 @@ class JITLinkRedirectableSymbolManager : public RedirectableSymbolManager {
   void emitRedirectableSymbols(std::unique_ptr<MaterializationResponsibility> R,
                                const SymbolAddrMap &InitialDests) override;
 
-  Error redirect(JITDylib &TargetJD, const SymbolAddrMap &NewDests) override;
+  Error redirect(JITDylib &JD, const SymbolAddrMap &NewDests) override;
 
 private:
   JITLinkRedirectableSymbolManager(

diff  --git a/llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp b/llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp
index 8c6d95374a6158..73136647994f9c 100644
--- a/llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp
@@ -67,7 +67,7 @@ void JITLinkRedirectableSymbolManager::emitRedirectableSymbols(
 }
 
 Error JITLinkRedirectableSymbolManager::redirect(
-    JITDylib &TargetJD, const SymbolAddrMap &NewDests) {
+    JITDylib &JD, const SymbolAddrMap &NewDests) {
   auto &ES = ObjLinkingLayer.getExecutionSession();
   SymbolLookupSet LS;
   DenseMap<NonOwningSymbolStringPtr, SymbolStringPtr> PtrToStub;
@@ -76,8 +76,8 @@ Error JITLinkRedirectableSymbolManager::redirect(
     PtrToStub[NonOwningSymbolStringPtr(PtrName)] = StubName;
     LS.add(std::move(PtrName));
   }
-  auto PtrSyms = ES.lookup({{&TargetJD, JITDylibLookupFlags::MatchAllSymbols}},
-                           std::move(LS));
+  auto PtrSyms =
+      ES.lookup({{&JD, JITDylibLookupFlags::MatchAllSymbols}}, std::move(LS));
   if (!PtrSyms)
     return PtrSyms.takeError();
 


        


More information about the llvm-commits mailing list