[llvm] [AMDGPU][MC] Fix disassembler problem for image_atomic with TFE (PR #112622)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 23 06:19:39 PDT 2024


================
@@ -192,10 +271,10 @@
 # VI: image_atomic_add v5, v1, s[8:15] dmask:0x2 unorm ; encoding: [0x00,0x12,0x48,0xf0,0x01,0x05,0x02,0x00]
 0x00,0x12,0x48,0xf0,0x01,0x05,0x02,0x00
 
-# VI: image_atomic_add v5, v1, s[8:15] dmask:0x7 unorm ; encoding: [0x00,0x17,0x48,0xf0,0x01,0x05,0x02,0x00]
+# VI: image_atomic_add v[5:7], v1, s[8:15] dmask:0x7 unorm ; encoding: [0x00,0x17,0x48,0xf0,0x01,0x05,0x02,0x00]
 0x00,0x17,0x48,0xf0,0x01,0x05,0x02,0x00
 
-# VI: image_atomic_add v[5:9], v1, s[8:15] dmask:0xf unorm ; encoding: [0x00,0x1f,0x48,0xf0,0x01,0x05,0x02,0x00]
+# VI: image_atomic_add v5, v1, s[8:15] dmask:0xf unorm ; encoding: [0x00,0x1f,0x48,0xf0,0x01,0x05,0x02,0x00]
----------------
jayfoad wrote:

Thanks for the explanation. It would still be nice to handle this better, either by printing the `v[5:8]` (maybe with a comment that something is wrong) or by diagnosing it properly as an error case.

https://github.com/llvm/llvm-project/pull/112622


More information about the llvm-commits mailing list