[llvm] [llvm-rc] Handle Windows line endings in tag-html test (PR #113000)
Daniel Paoliello via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 21 14:55:59 PDT 2024
dpaoliello wrote:
> Are you seeing those issues still if you rebase your branch to a recent base version?
>
> See #86318 for the source of those issues - that was reverted in [e669bbb](https://github.com/llvm/llvm-project/commit/e669bbbb7265a7d4d59bac2d3889194efa167ea8). And there's a chance that it can end up reapplied with `.gitattributes` enforcing checking out these files with LF newlines.
I'm still seeing failures in the CI machines - even with that change reverted, I don't think that it's forcing Git to re-create the files with the correct line endings.
Just looking through recent PRs with build failures, I see <https://buildkite.com/llvm-project/github-pull-requests/builds/111934#0192b0c1-cdad-4ace-936e-93d0626d903d> which has the revert in its commit history, but is still failing due to this issue (and the other which I recently merged a fix for).
https://github.com/llvm/llvm-project/pull/113000
More information about the llvm-commits
mailing list