[llvm] [llvm-rc] Handle Windows line endings in tag-html test (PR #113000)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 21 13:48:48 PDT 2024


mstorsjo wrote:

> @llvm/pr-subscribers-windows can I believe get a review for this: it fixes the last failure we've been seeing in the PR builds for Windows.

Are you seeing those issues still?

See https://github.com/llvm/llvm-project/pull/86318 for the source of those issues - that was reverted in e669bbbb7265a7d4d59bac2d3889194efa167ea8. And there's a chance that it can end up reapplied with `.gitattributes` enforcing checking out these files with LF newlines.

That said, it would of course be nice if the tests pass even if checked out with CRLF, so I guess this fix can be acceptable for that. It's not really ideal, but could work.

A different alternative could be to mark specifically those `Inputs` files as explicitly requiring LF newlines. Earlier, all of these `Inputs` were marked as binary, but that was pretty annoying for any diff operation, so I changed that in e46822e507e14c7f64ab4eb93c9d20e284c77e02. But I guess it could work to add a similar annotation for specifically those `webpage*.html` to enforce LF newlines on it, always?

https://github.com/llvm/llvm-project/pull/113000


More information about the llvm-commits mailing list