[llvm] [tools] Don't call StringRef::str() when calling StringMap::find (NFC) (PR #113119)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Oct 20 18:44:32 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-pgo
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
StringMap::find takes StringRef. We don't need to create an instance
of std::string from StringRef only to convert it right back to
StringRef.
---
Full diff: https://github.com/llvm/llvm-project/pull/113119.diff
2 Files Affected:
- (modified) llvm/tools/llvm-profdata/llvm-profdata.cpp (+2-2)
- (modified) llvm/tools/llvm-readtapi/llvm-readtapi.cpp (+1-1)
``````````diff
diff --git a/llvm/tools/llvm-profdata/llvm-profdata.cpp b/llvm/tools/llvm-profdata/llvm-profdata.cpp
index c235c3f2b105e1..59f0f1f1fae899 100644
--- a/llvm/tools/llvm-profdata/llvm-profdata.cpp
+++ b/llvm/tools/llvm-profdata/llvm-profdata.cpp
@@ -1297,7 +1297,7 @@ adjustInstrProfile(std::unique_ptr<WriterContext> &WC,
} else {
auto NewName = StaticFuncMap.find(Name);
if (NewName != StaticFuncMap.end()) {
- It = InstrProfileMap.find(NewName->second.str());
+ It = InstrProfileMap.find(NewName->second);
if (NewName->second != DuplicateNameStr) {
NewRootName = &NewName->second;
}
@@ -1382,7 +1382,7 @@ adjustInstrProfile(std::unique_ptr<WriterContext> &WC,
if (It == InstrProfileMap.end()) {
auto NewName = StaticFuncMap.find(Name);
if (NewName != StaticFuncMap.end()) {
- It = InstrProfileMap.find(NewName->second.str());
+ It = InstrProfileMap.find(NewName->second);
if (NewName->second == DuplicateNameStr) {
WithColor::warning()
<< "Static function " << Name
diff --git a/llvm/tools/llvm-readtapi/llvm-readtapi.cpp b/llvm/tools/llvm-readtapi/llvm-readtapi.cpp
index 1d740109d5b679..7390d0ec4b79a3 100644
--- a/llvm/tools/llvm-readtapi/llvm-readtapi.cpp
+++ b/llvm/tools/llvm-readtapi/llvm-readtapi.cpp
@@ -382,7 +382,7 @@ static void stubifyDirectory(const StringRef InputPath, Context &Ctx) {
// libraries to stubify.
StringRef LibToCheck = Found->second;
for (int i = 0; i < 20; ++i) {
- auto LinkIt = SymLinks.find(LibToCheck.str());
+ auto LinkIt = SymLinks.find(LibToCheck);
if (LinkIt != SymLinks.end()) {
for (auto &SymInfo : LinkIt->second) {
SmallString<PATH_MAX> LinkSrc(SymInfo.SrcPath);
``````````
</details>
https://github.com/llvm/llvm-project/pull/113119
More information about the llvm-commits
mailing list