[llvm] [DebugInfo] Use heterogenous lookups with std::map (NFC) (PR #113118)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Oct 20 18:40:55 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-debuginfo
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/113118.diff
2 Files Affected:
- (modified) llvm/include/llvm/DebugInfo/LogicalView/Readers/LVBinaryReader.h (+1-1)
- (modified) llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp (+4-4)
``````````diff
diff --git a/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVBinaryReader.h b/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVBinaryReader.h
index f76f2ecd3e2121..9cda64e33ddf74 100644
--- a/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVBinaryReader.h
+++ b/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVBinaryReader.h
@@ -47,7 +47,7 @@ struct LVSymbolTableEntry final {
// Function names extracted from the object symbol table.
class LVSymbolTable final {
- using LVSymbolNames = std::map<std::string, LVSymbolTableEntry>;
+ using LVSymbolNames = std::map<std::string, LVSymbolTableEntry, std::less<>>;
LVSymbolNames SymbolNames;
public:
diff --git a/llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp b/llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp
index c45f0e91c43589..932346e1b011bf 100644
--- a/llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp
+++ b/llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp
@@ -87,20 +87,20 @@ LVSectionIndex LVSymbolTable::update(LVScope *Function) {
const LVSymbolTableEntry &LVSymbolTable::getEntry(StringRef Name) {
static LVSymbolTableEntry Empty = LVSymbolTableEntry();
- LVSymbolNames::iterator Iter = SymbolNames.find(std::string(Name));
+ LVSymbolNames::iterator Iter = SymbolNames.find(Name);
return Iter != SymbolNames.end() ? Iter->second : Empty;
}
LVAddress LVSymbolTable::getAddress(StringRef Name) {
- LVSymbolNames::iterator Iter = SymbolNames.find(std::string(Name));
+ LVSymbolNames::iterator Iter = SymbolNames.find(Name);
return Iter != SymbolNames.end() ? Iter->second.Address : 0;
}
LVSectionIndex LVSymbolTable::getIndex(StringRef Name) {
- LVSymbolNames::iterator Iter = SymbolNames.find(std::string(Name));
+ LVSymbolNames::iterator Iter = SymbolNames.find(Name);
return Iter != SymbolNames.end() ? Iter->second.SectionIndex
: getReader().getDotTextSectionIndex();
}
bool LVSymbolTable::getIsComdat(StringRef Name) {
- LVSymbolNames::iterator Iter = SymbolNames.find(std::string(Name));
+ LVSymbolNames::iterator Iter = SymbolNames.find(Name);
return Iter != SymbolNames.end() ? Iter->second.IsComdat : false;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/113118
More information about the llvm-commits
mailing list