[llvm] [InstCombine] Fix for folding `select` into floating point binary operators. (PR #83200)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 20 16:28:15 PDT 2024


arsenm wrote:

> I'd need to know if such change makes sense before working on a PR with a proper test case. 

You need a proper test case to make sense of the situation. It would be easier to reason about and discuss with a concrete 3 line IR testcase than this 

> Namely, is obtaining information from `TVI` the right thing to do when `SI` doesn't seem to have it.

computeKnownFPClass knows a few tricks operating directly on the select based on the compared values. It would help to see the reduced example

https://github.com/llvm/llvm-project/pull/83200


More information about the llvm-commits mailing list