[llvm] Update the EBO static_assert to dheck against APFloat::Storage instead of IEEEFloat. (PR #112589)
Daniel Chen via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 18 07:40:26 PDT 2024
DanielCChen wrote:
> I would like to keep the assertion as-is. It found a legitimate issue with your downstream changes: That they increase the size of APFloat.
>
> You should drop the assertion downstream for now. When you upstream your changes, we can consider whether we are willing to take that size increase or not, and adjust the assertion accordingly at that time.
Ok. That is fair. We will bring it back once we are ready to upstream our code in the future.
Thanks again to everyone for reviewing it.
https://github.com/llvm/llvm-project/pull/112589
More information about the llvm-commits
mailing list