[llvm] c742a5d - [NFC] Fix multi-character character constant warning (#112809)

via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 18 06:01:04 PDT 2024


Author: Jinsong Ji
Date: 2024-10-18T09:01:01-04:00
New Revision: c742a5dc2e67e1f0020a1fd9f602b369b740eafc

URL: https://github.com/llvm/llvm-project/commit/c742a5dc2e67e1f0020a1fd9f602b369b740eafc
DIFF: https://github.com/llvm/llvm-project/commit/c742a5dc2e67e1f0020a1fd9f602b369b740eafc.diff

LOG: [NFC] Fix multi-character character constant warning (#112809)

This is one of the many PRs to fix errors with LLVM_ENABLE_WERROR=on.
Built by GCC 11.

Fix warning:

In file included from llvm-project/llvm/lib/BinaryFormat/Minidump.cpp:9:
llvm-project/llvm/include/llvm/BinaryFormat/Minidump.h:250:37: error:
multi-character character constant [-Werror=multichar]
  250 |   static const uint32_t LLDB_FLAG = 'LLDB';

Added: 
    

Modified: 
    llvm/include/llvm/BinaryFormat/Minidump.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/BinaryFormat/Minidump.h b/llvm/include/llvm/BinaryFormat/Minidump.h
index addff42982352f..03497d4c5fa66f 100644
--- a/llvm/include/llvm/BinaryFormat/Minidump.h
+++ b/llvm/include/llvm/BinaryFormat/Minidump.h
@@ -247,7 +247,7 @@ static_assert(sizeof(Thread) == 48);
 struct Exception {
   static constexpr size_t MaxParameters = 15;
   static constexpr size_t MaxParameterBytes = MaxParameters * sizeof(uint64_t);
-  static const uint32_t LLDB_FLAG = 'LLDB';
+  static const uint32_t LLDB_FLAG = 0x4C4C4442; // ASCII for 'LLDB'
 
   support::ulittle32_t ExceptionCode;
   support::ulittle32_t ExceptionFlags;


        


More information about the llvm-commits mailing list