[llvm] [SYCL][LLVM] Adding property set I/O library for SYCL (PR #110771)
Chris B via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 17 10:25:50 PDT 2024
llvm-beanz wrote:
> One of my colleagues had tried to switch to YAML some time ago, but that effort got stuck pretty quickly. The main problem that we encountered with switching to YAML was lack of flexibility: we don't know how many SYCL properties there will be and SYCL properties within a single set (which could have been represented as an array) may have different types (which makes it hard to represent them as an array).
YAML files can contain multiple "documents" as well. I'm not sure I see how YAML is unsuitable for this use case.
That aside, it really seems to me that this design decision has a bunch of different implications.
If we go forward with this solution I think we need _a lot_ more tests of the parser itself since parsing is generally a source of security bugs.
https://github.com/llvm/llvm-project/pull/110771
More information about the llvm-commits
mailing list