https://github.com/jh7370 commented: Looks good, barring the remaining nits. I'll give it one more once-over once you've addressed those to make sure I haven't missed anything, before formally approving. https://github.com/llvm/llvm-project/pull/111871