[llvm] [APInt] Enable APInt ctor assertion by default (PR #112670)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 17 00:38:58 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-adt
Author: Nikita Popov (nikic)
<details>
<summary>Changes</summary>
This enables the assertion introduced in https://github.com/llvm/llvm-project/pull/106524, which checks that the value passed to the APInt constructor is indeed a valid N-bit signed or unsigned integer.
Places that previously violated the assertion were updated in advance, e.g. in https://github.com/llvm/llvm-project/pull/80309.
It is possible to opt-out of the check and restore the previous behavior by setting implicitTrunc=true.
---
Full diff: https://github.com/llvm/llvm-project/pull/112670.diff
1 Files Affected:
- (modified) llvm/include/llvm/ADT/APInt.h (+1-1)
``````````diff
diff --git a/llvm/include/llvm/ADT/APInt.h b/llvm/include/llvm/ADT/APInt.h
index 63a138527b32e1..953b2a27b71526 100644
--- a/llvm/include/llvm/ADT/APInt.h
+++ b/llvm/include/llvm/ADT/APInt.h
@@ -109,7 +109,7 @@ class [[nodiscard]] APInt {
/// \param implicitTrunc allow implicit truncation of non-zero/sign bits of
/// val beyond the range of numBits
APInt(unsigned numBits, uint64_t val, bool isSigned = false,
- bool implicitTrunc = true)
+ bool implicitTrunc = false)
: BitWidth(numBits) {
if (!implicitTrunc) {
if (isSigned) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/112670
More information about the llvm-commits
mailing list