[llvm] [AMDGPU] Implement hasAndNot for scalar bitwise AND-NOT operations. (PR #112647)

Harrison Hao via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 23:24:31 PDT 2024


harrisonGPU wrote:

> Needs tests (most of the effort on this patch is adding the requisite tests).
> 
> We need coverage with all the combinations of SGPR / VGPR inputs in i1 / i8 / i16 / i32 / i64 for the basic and-not pattern.
> 
> Additionally we need some tests for the optimizations enabled by this hook.
> 
> https://github.com/llvm/llvm-project/blob/1b4a173fa41e02eddec9f1cf41324aa4ea8a7fa5/llvm/test/CodeGen/AMDGPU/xor3.ll#L27
> 
> is one example.
> Use arguments with inreg to get sample SGPR inputs, otherwise VGPR

Okay, I need to consider how to add test for this patch. :)

https://github.com/llvm/llvm-project/pull/112647


More information about the llvm-commits mailing list