[llvm] [RISCV] Mark math functions as expanded for zvfhmin/zvfbfmin (PR #112508)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 10:40:49 PDT 2024


topperc wrote:

> > Reasonable to me. Just one question, why is there no CodeGen change? I suppose we should have some.
> 
> I thought the same thing as well, but I couldn't find any existing CodeGen tests to extend. I guess the original commit that set them to expand was mainly testing that the vectorizers wouldn't emit any of these.

You can't really write a CodeGen test for them unless you use "not" and check for the error message. Without this patch they probably get a "cannot select" error from isel. With this patch they'll fail when LegalizeDAG tries to unroll them which can't be done for a scalable vector.

https://github.com/llvm/llvm-project/pull/112508


More information about the llvm-commits mailing list