[llvm] [RISCV] Separate HW/SW shadow stack on RISC-V (PR #112478)

Ming-Yi Lai via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 16 04:05:14 PDT 2024


================
@@ -73,7 +77,7 @@ static void emitSCSPrologue(MachineFunction &MF, MachineBasicBlock &MBB,
     return;
 
   const RISCVInstrInfo *TII = STI.getInstrInfo();
-  if (!STI.hasForcedSWShadowStack() && STI.hasStdExtZicfiss()) {
+  if (HasHWShadowStack) {
     BuildMI(MBB, MI, DL, TII->get(RISCV::SSPUSH)).addReg(RAReg);
----------------
mylai-mtk wrote:

I would have concern of using `SSPUSH` here since the only check performed here is `STI.hasStdExtZimop()`, but in tablegen, the predicate of `SSPUSH` (and friends) is `HasStdExtZicfiss`.

https://github.com/llvm/llvm-project/pull/112478


More information about the llvm-commits mailing list