[llvm] [SYCL][LLVM] Adding property set I/O library for SYCL (PR #110771)

Chris B via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 14:37:20 PDT 2024


llvm-beanz wrote:

> In the meanwhile, I have added some description inside the summary of this PR. Hope that answers some of your queries here.

The description in the summary doesn't really explain how this is used other than "to pass information about specialization constants, etc, to the SYCL runtime."

That's not really descriptive, and doesn't explain why this new textual format was designed. Some specific questions:
1) Is this text format part of the SYCL specification, or is it an implementation detail?
2) If it is an implementation detail, can it be changed to a standard defined textual format (YAML, JSON, XML)? I ask this specifically because custom serialization formats are often great targets for security vulnerabilities, so using a standardized and defined format is preferable to making your own. Obviously if this is a required part of the SYCL specification that has different considerations.
3) How is this used during the compiler? Specifically, where are they generated, and where are they consumed?


https://github.com/llvm/llvm-project/pull/110771


More information about the llvm-commits mailing list