[llvm] 97da5e6 - [GSYM] Remove redundant getInliningInfoForAddress call (#111136)

[via llvm-commits]

Author: David Stenberg
Date: 2024-10-15T13:34:27-07:00
New Revision: 97da5e670099848f7d136a6988afd6ea638e2210

URL: https://github.com/llvm/llvm-project/commit/97da5e670099848f7d136a6988afd6ea638e2210
DIFF: https://github.com/llvm/llvm-project/commit/97da5e670099848f7d136a6988afd6ea638e2210.diff

LOG: [GSYM] Remove redundant getInliningInfoForAddress call (#111136)

In DwarfTransformer::verify() line number information is retrieved for
each address using:

  auto DwarfInlineInfos =
      DICtx.getInliningInfoForAddress(SectAddr, DLIS);

Later down the loop, another such invocation was made before:

  Gsym->dump(Log, *FI);

There is a continue after that, DwarfInlineInfos do not affect the
dump() invocation, I am not aware of any other side effects that is
needed from the extra getInliningInfoForAddress() invocation, and tests
pass without it, so just remove it.

Added: 
    

Modified: 
    llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp b/llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
index 894abf5777f161..3f5604e6aa4b06 100644
--- a/llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
+++ b/llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
@@ -699,7 +699,6 @@ llvm::Error DwarfTransformer::verify(StringRef GsymPath,
             Log << "    [" << Idx << "]: " << gii.Name << " @ " << gii.Dir
                 << '/' << gii.Base << ':' << gii.Line << '\n';
           }
-          DwarfInlineInfos = DICtx.getInliningInfoForAddress(SectAddr, DLIS);
           Gsym->dump(Log, *FI);
         }
         continue;