[llvm] [SandboxVec] Add pass to create Regions from metadata. Generalize SandboxVec pass pipelines. (PR #112288)
Jorge Gorbe Moya via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 15 12:02:13 PDT 2024
================
@@ -43,7 +43,7 @@ class Pass {
LLVM_DUMP_METHOD virtual void dump() const;
#endif
/// Similar to print() but adds a newline. Used for testing.
- void printPipeline(raw_ostream &OS) const { OS << Name << "\n"; }
+ virtual void printPipeline(raw_ostream &OS) const { OS << Name << "\n"; }
----------------
slackito wrote:
That's the code that implements the `-sbvec-print-pass-pipeline` flag. And it wasn't guarded before. Do we want the flag to only work in debug builds? If so, should we guard the flag as well (and then the tests that rely on printing the pass pipeline will become unsupported in release builds)? I think those questions are out of scope for this PR.
https://github.com/llvm/llvm-project/pull/112288
More information about the llvm-commits
mailing list