[llvm] [DXIL] Add GroupMemoryBarrierWithGroupSync intrinsic (PR #111884)

Finn Plummer via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 11:47:26 PDT 2024


================
@@ -477,6 +500,11 @@ class OpLowerer {
     HasErrors |= replaceFunctionWithOp(F, OpCode);                             \
     break;
 #include "DXILOperation.inc"
+      case Intrinsic::dx_group_memory_barrier_with_group_sync:
----------------
inbelic wrote:

I think we could also approach this as an intrinsic expansion. So we would create a DirectX intrinsic `dx_group_memory_barrier` that would lower here. Then we would deal with `dx_group_memory_barrier_with_group_sync` and all the other barrier ops as an intrinsic expansion with the applicable opcode and barrier modes.

I think that would be clearer when adding future barrier ops and match the flow of other intrinsics. WDYT?

https://github.com/llvm/llvm-project/pull/111884


More information about the llvm-commits mailing list