[lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 10:22:41 PDT 2024


================
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
   /// Set the language using a pair of language code and version as
   /// defined by the DWARF 6 specification.
   /// WARNING: These codes may change until DWARF 6 is finalized.
-  void SetLanguage(lldb::SBSourceLanguageName name, uint32_t version);
+  void SetLanguage(lldb::SourceLanguageName name, uint32_t version);
----------------
jimingham wrote:

We don't have a formal policy about "provisional additions to the SB API".  The warning about the values change clearly means: "If you use this API, you will have to recompile against the version of lldb you intend to use."  So it is explicitly saying it's an unstable API.

Best would be to not do this, but if we find ourselves in a position where we have to, then we probably should require you to define `ALLOW_LLDB_UNSTABLE_SB_APIS` or some such, and guard unstable API's based on that.

https://github.com/llvm/llvm-project/pull/111929


More information about the llvm-commits mailing list