[llvm] [LLVM][NFC] Remove redundant copy parameter in lambda (PR #110299)
Amr Hesham via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 15 09:22:36 PDT 2024
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/110299
>From b9cc43b5df6ee277affcdc0864c962393fd36e9f Mon Sep 17 00:00:00 2001
From: AmrDeveloper <amr96 at programmer.net>
Date: Fri, 27 Sep 2024 18:59:04 +0200
Subject: [PATCH] [LLVM][NFC] Reduce redundant copy parameter in lambda
---
llvm/lib/Analysis/VectorUtils.cpp | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/llvm/lib/Analysis/VectorUtils.cpp b/llvm/lib/Analysis/VectorUtils.cpp
index dbffbb8a5f81d9..6b5251e0ad34eb 100644
--- a/llvm/lib/Analysis/VectorUtils.cpp
+++ b/llvm/lib/Analysis/VectorUtils.cpp
@@ -1414,7 +1414,7 @@ void InterleavedAccessInfo::analyzeInterleaving(
auto InvalidateGroupIfMemberMayWrap = [&](InterleaveGroup<Instruction> *Group,
int Index,
- std::string FirstOrLast) -> bool {
+ const char *FirstOrLast) -> bool {
Instruction *Member = Group->getMember(Index);
assert(Member && "Group member does not exist");
Value *MemberPtr = getLoadStorePointerOperand(Member);
@@ -1455,11 +1455,10 @@ void InterleavedAccessInfo::analyzeInterleaving(
// So we check only group member 0 (which is always guaranteed to exist),
// and group member Factor - 1; If the latter doesn't exist we rely on
// peeling (if it is a non-reversed access -- see Case 3).
- if (InvalidateGroupIfMemberMayWrap(Group, 0, std::string("first")))
+ if (InvalidateGroupIfMemberMayWrap(Group, 0, "first"))
continue;
if (Group->getMember(Group->getFactor() - 1))
- InvalidateGroupIfMemberMayWrap(Group, Group->getFactor() - 1,
- std::string("last"));
+ InvalidateGroupIfMemberMayWrap(Group, Group->getFactor() - 1, "last");
else {
// Case 3: A non-reversed interleaved load group with gaps: We need
// to execute at least one scalar epilogue iteration. This will ensure
@@ -1503,11 +1502,11 @@ void InterleavedAccessInfo::analyzeInterleaving(
// and the last group member. Case 3 (scalar epilog) is not relevant for
// stores with gaps, which are implemented with masked-store (rather than
// speculative access, as in loads).
- if (InvalidateGroupIfMemberMayWrap(Group, 0, std::string("first")))
+ if (InvalidateGroupIfMemberMayWrap(Group, 0, "first"))
continue;
for (int Index = Group->getFactor() - 1; Index > 0; Index--)
if (Group->getMember(Index)) {
- InvalidateGroupIfMemberMayWrap(Group, Index, std::string("last"));
+ InvalidateGroupIfMemberMayWrap(Group, Index, "last");
break;
}
}
More information about the llvm-commits
mailing list