[llvm] ValueTracking: introduce llvm::isNotCrossLaneOperation (PR #112011)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 07:41:10 PDT 2024


preames wrote:

> > Naming wise, isNotLaneCrossingOperation seems like a double negative. I believe we've called this lane or element wise operations elsewhere, maybe isLanewiseOperation would be better?
> 
> See this comment thread: [#112011 (comment)](https://github.com/llvm/llvm-project/pull/112011#discussion_r1797702539)

Distinction understood, but seems like either a) we should add the ElementWise predicate too because many operations are element wise or b) we should at least update the doc comment to explain the distinction.  I certainly hadn't gotten it from either skimming this review or the change.  


https://github.com/llvm/llvm-project/pull/112011


More information about the llvm-commits mailing list