[compiler-rt] [compiler-rt] DumpAllRegisters for windows arm64 fix unit test (PR #112329)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 15 01:24:03 PDT 2024


================
@@ -17,7 +17,7 @@ int main() {
   // CHECK-DUMP-NEXT:x16 = {{0x[0-9a-f]+}}  x17 = {{0x[0-9a-f]+}}  x18 = {{0x[0-9a-f]+}}  x19 = {{0x[0-9a-f]+}}
----------------
mstorsjo wrote:

Commenting on the context above - the test runs with `--strict-whitespace`, but I believe the whitespace might not be right.

Both in the original incarnation in #112254, and in the revised form in #112305, registers below 10 are spaced as `x0<space><space>= ...`, while the test above seems to assume the spacing to be `<space>x0<space>= ...`.

Additionally, in the original form in #112254 we did have spaces between the elements (but no line wrapping). In the revised form in #112305, we do have line wrapping as the test expects, but we seem to have lost the spaces between elements.

I appreciate the contributions, but if the tests aren't ever actually tested to work correctly, then please raise that during review, to ask someone to test it for you before merging!

Do @DavidSpickett or @omjavaid have an environment handy where you can run these tests?

https://github.com/llvm/llvm-project/pull/112329


More information about the llvm-commits mailing list