[llvm] bc09beb - [AMDGPU] Avoid repeated hash lookups (NFC) (#112309)

via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 14 23:09:32 PDT 2024


Author: Kazu Hirata
Date: 2024-10-14T23:09:28-07:00
New Revision: bc09bebcc2a8da4544b43c456240e8dac0c4375b

URL: https://github.com/llvm/llvm-project/commit/bc09bebcc2a8da4544b43c456240e8dac0c4375b
DIFF: https://github.com/llvm/llvm-project/commit/bc09bebcc2a8da4544b43c456240e8dac0c4375b.diff

LOG: [AMDGPU] Avoid repeated hash lookups (NFC) (#112309)

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp b/llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp
index 50f536c532afc7..162270524263cd 100644
--- a/llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp
+++ b/llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp
@@ -189,7 +189,7 @@ void SIOptimizeVGPRLiveRange::collectElseRegionBlocks(
   unsigned Cur = 0;
   while (MBB) {
     for (auto *Pred : MBB->predecessors()) {
-      if (Pred != Flow && !Blocks.contains(Pred))
+      if (Pred != Flow)
         Blocks.insert(Pred);
     }
 
@@ -407,10 +407,8 @@ void SIOptimizeVGPRLiveRange::updateLiveRangeInThenRegion(
   while (!WorkList.empty()) {
     auto *MBB = WorkList.pop_back_val();
     for (auto *Succ : MBB->successors()) {
-      if (Succ != Flow && !Blocks.contains(Succ)) {
+      if (Succ != Flow && Blocks.insert(Succ))
         WorkList.push_back(Succ);
-        Blocks.insert(Succ);
-      }
     }
   }
 


        


More information about the llvm-commits mailing list