[llvm] [SandboxVec] Add pass to create Regions from metadata. Generalize SandboxVec pass pipelines. (PR #112288)

via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 14 18:07:09 PDT 2024


================
@@ -308,8 +314,21 @@ define void @f() {
   // Fresh PM for the death tests so they die from bad pipeline strings, rather
   // than from multiple setPassPipeline calls.
   FunctionPassManager FPM2("test-fpm");
+  // Bad/empty pass names.
   EXPECT_DEATH(FPM2.setPassPipeline("bad-pass-name", CreatePass),
                ".*not registered.*");
-  EXPECT_DEATH(FPM2.setPassPipeline("", CreatePass), ".*not registered.*");
-  EXPECT_DEATH(FPM2.setPassPipeline(",", CreatePass), ".*not registered.*");
+  EXPECT_DEATH(FPM2.setPassPipeline(",", CreatePass), ".*empty pass name.*");
+  EXPECT_DEATH(FPM2.setPassPipeline("<>", CreatePass), ".*empty pass name.*");
+  EXPECT_DEATH(FPM2.setPassPipeline("foo,<>", CreatePass),
+               ".*empty pass name.*");
+
+  // Mismatched argument brackets.
+  EXPECT_DEATH(FPM2.setPassPipeline("foo<", CreatePass), ".*");
+  EXPECT_DEATH(FPM2.setPassPipeline("foo>", CreatePass), ".*");
+  EXPECT_DEATH(FPM2.setPassPipeline("foo<bar<>", CreatePass), ".*");
+  EXPECT_DEATH(FPM2.setPassPipeline("foo<bar<>>>", CreatePass), ".*");
+  EXPECT_DEATH(FPM2.setPassPipeline(">foo", CreatePass), ".*");
+  EXPECT_DEATH(FPM2.setPassPipeline("<>foo", CreatePass), ".*");
+  EXPECT_DEATH(FPM2.setPassPipeline("foo<args><more-args>", CreatePass), ".*");
+  EXPECT_DEATH(FPM2.setPassPipeline("foo<args>bar", CreatePass), ".*");
----------------
vporpo wrote:

`EXPECT_DEATH(FPM2.setPassPipeline("foo<bar"));`

https://github.com/llvm/llvm-project/pull/112288


More information about the llvm-commits mailing list