[llvm] [CMake][Windows] Fix Debug config build when using MSBuild (PR #111765)

NAKAMURA Takumi via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 14 03:22:05 PDT 2024


================
@@ -191,9 +191,13 @@ macro(add_tablegen target project)
 
   # FIXME: Quick fix to reflect LLVM_TABLEGEN to llvm-min-tblgen
   if("${target}" STREQUAL "llvm-min-tblgen"
-      AND NOT "${LLVM_TABLEGEN}" STREQUAL ""
-      AND NOT "${LLVM_TABLEGEN}" STREQUAL "llvm-tblgen")
-    set(${project}_TABLEGEN_DEFAULT "${LLVM_TABLEGEN}")
+      AND NOT "${LLVM_TABLEGEN}" STREQUAL "")
+    # Extract base filename from full path.
+    get_filename_component(RAW_LLVM_TABLEGEN ${LLVM_TABLEGEN} NAME_WE)
----------------
chapuni wrote:

I wonder `get_filename_component` would be applicable here.
Would it match if `${LLVM_TABLEGEN}` points the explicit out-of-tree `/path/to/llvm-tblgen.exe`?

`${LLVM_HOST_EXECUTABLE_SUFFIX}` may be available here, I guess.

https://github.com/llvm/llvm-project/pull/111765


More information about the llvm-commits mailing list