[llvm] 30f5a3c - [MCJIT][ORC] Change test guards to 'UNSUPPORTED: system-darwin'.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 23:44:46 PDT 2024


Author: Lang Hames
Date: 2024-09-27T16:44:38+10:00
New Revision: 30f5a3ca150e98d482abc6a4d0e3fe6c12f77695

URL: https://github.com/llvm/llvm-project/commit/30f5a3ca150e98d482abc6a4d0e3fe6c12f77695
DIFF: https://github.com/llvm/llvm-project/commit/30f5a3ca150e98d482abc6a4d0e3fe6c12f77695.diff

LOG: [MCJIT][ORC] Change test guards to 'UNSUPPORTED: system-darwin'.

These tests were guarded with 'UNSUPPORTED: target={{.*}}-darwin{{.*}}', but
that check may unintentionally pass if LLVM is configured with a host triple
that specifies a specific Darwin flavor, e.g. macOS with
-DLLVM_HOST_TRIPLE:STRING=aarch64-apple-macosx13.0. All darwin flavors should
set 'system-darwin', so this is a safer feature to check.

rdar://134942819

Added: 
    

Modified: 
    llvm/test/ExecutionEngine/MCJIT/test-global-ctors.ll
    llvm/test/ExecutionEngine/Orc/weak-comdat.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/ExecutionEngine/MCJIT/test-global-ctors.ll b/llvm/test/ExecutionEngine/MCJIT/test-global-ctors.ll
index 2e95e7eda588a1..4598c9f71f14cc 100644
--- a/llvm/test/ExecutionEngine/MCJIT/test-global-ctors.ll
+++ b/llvm/test/ExecutionEngine/MCJIT/test-global-ctors.ll
@@ -1,6 +1,6 @@
 ; RUN: %lli -jit-kind=mcjit %s > /dev/null
 ; RUN: %lli %s > /dev/null
-; UNSUPPORTED: target={{.*}}-darwin{{.*}}
+; UNSUPPORTED: system-darwin
 @var = global i32 1, align 4
 @llvm.global_ctors = appending global [1 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 65535, ptr @ctor_func, ptr null }]
 @llvm.global_dtors = appending global [1 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 65535, ptr @dtor_func, ptr null }]

diff  --git a/llvm/test/ExecutionEngine/Orc/weak-comdat.ll b/llvm/test/ExecutionEngine/Orc/weak-comdat.ll
index e1e1ab02e2981b..4ebbfdf4aa35b0 100644
--- a/llvm/test/ExecutionEngine/Orc/weak-comdat.ll
+++ b/llvm/test/ExecutionEngine/Orc/weak-comdat.ll
@@ -1,5 +1,5 @@
 ; RUN: lli -extra-module %p/Inputs/weak-comdat-def.ll %s
-; UNSUPPORTED: target={{.*}}-darwin{{.*}}
+; UNSUPPORTED: system-darwin
 
 declare i32 @g()
 


        


More information about the llvm-commits mailing list