[llvm] [X86] Don't request 0x90 nop filling in p2align directives (PR #110134)

Sam Elliott via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 09:32:49 PDT 2024


lenary wrote:

I agree it's undesirable for the text assembler to do something different to integrated assembler. Sorry I didn't notice this before.

x86 is the only (upstream) target using `TextAlignFillValue` - maybe that whole mechanism in MCAsmInfo should be removed if it will only be set upstream to the default value (0)?

At the very least, the x86 target doesn't need to set this to its documented default value, so you can probably delete all assignments to `TextAlignFillValue`.







https://github.com/llvm/llvm-project/pull/110134


More information about the llvm-commits mailing list