[llvm] [ctx_prof] Fix `ProfileAnnotator::allTakenPathsExit` (PR #109183)

Wed Sep 18 21:11:55 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx` running on `linaro-flang-aarch64-libcxx` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/89/builds/6666

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
34.774 [4412/13/2762] Building VectorOps.h.inc...
34.774 [4412/12/2763] Building VectorTransformOps.h.inc...
34.774 [4412/11/2764] Building Passes.h.inc...
34.774 [4412/10/2765] Building X86Vector.cpp.inc...
34.774 [4412/9/2766] Building X86Vector.h.inc...
34.775 [4412/8/2767] Building X86VectorDialect.cpp.inc...
34.775 [4412/7/2768] Building X86VectorDialect.h.inc...
34.775 [4412/6/2769] Building X86VectorTypes.cpp.inc...
38.402 [4412/5/2770] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/IRSymtab.cpp.o
39.033 [4412/4/2771] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o
FAILED: lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o 
/usr/local/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/lib/Transforms/Instrumentation -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/lib/Transforms/Instrumentation -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/include -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o -MF lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o.d -o lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/lib/Transforms/Instrumentation/PGOCtxProfFlattening.cpp
In file included from ../llvm-project/llvm/lib/Transforms/Instrumentation/PGOCtxProfFlattening.cpp:21:
In file included from ../llvm-project/llvm/include/llvm/Transforms/Instrumentation/PGOCtxProfFlattening.h:15:
In file included from ../llvm-project/llvm/include/llvm/IR/PassManager.h:40:
In file included from ../llvm-project/llvm/include/llvm/ADT/DenseMap.h:25:
In file included from /usr/local/clang+llvm-18.1.8-aarch64-linux-gnu/bin/../include/c++/v1/algorithm:1795:
/usr/local/clang+llvm-18.1.8-aarch64-linux-gnu/bin/../include/c++/v1/__algorithm/copy_backward.h:98:68: error: invalid operands to binary expression ('llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>' and 'long')
   98 |       auto __iter        = std::__copy_backward<_AlgPolicy>(__last - __size, __last, __local_last).second;
      |                                                             ~~~~~~ ^ ~~~~~~
/usr/local/clang+llvm-18.1.8-aarch64-linux-gnu/bin/../include/c++/v1/__algorithm/copy_move_common.h:109:19: note: in instantiation of function template specialization 'std::__copy_backward_loop<std::_ClassicAlgPolicy>::operator()<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>, 0>' requested here
  109 |   auto __result = _Algorithm()(std::move(__range.first), std::move(__range.second), std::__unwrap_iter(__out_first));
      |                   ^
/usr/local/clang+llvm-18.1.8-aarch64-linux-gnu/bin/../include/c++/v1/__algorithm/copy_move_common.h:133:15: note: in instantiation of function template specialization 'std::__unwrap_and_dispatch<std::__overload<std::__copy_backward_loop<std::_ClassicAlgPolicy>, std::__copy_backward_trivial>, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>, 0>' requested here
  133 |   return std::__unwrap_and_dispatch<_Algorithm>(std::move(__first), std::move(__last), std::move(__out_first));
      |               ^
/usr/local/clang+llvm-18.1.8-aarch64-linux-gnu/bin/../include/c++/v1/__algorithm/copy_backward.h:121:15: note: in instantiation of function template specialization 'std::__dispatch_copy_or_move<std::_ClassicAlgPolicy, std::__copy_backward_loop<std::_ClassicAlgPolicy>, std::__copy_backward_trivial, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>>' requested here
  121 |   return std::__dispatch_copy_or_move<_AlgPolicy, __copy_backward_loop<_AlgPolicy>, __copy_backward_trivial>(
      |               ^
/usr/local/clang+llvm-18.1.8-aarch64-linux-gnu/bin/../include/c++/v1/__algorithm/copy_backward.h:132:15: note: in instantiation of function template specialization 'std::__copy_backward<std::_ClassicAlgPolicy, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>>' requested here
  132 |   return std::__copy_backward<_ClassicAlgPolicy>(std::move(__first), std::move(__last), std::move(__result)).second;
      |               ^
/usr/local/clang+llvm-18.1.8-aarch64-linux-gnu/bin/../include/c++/v1/deque:1929:12: note: in instantiation of function template specialization 'std::copy_backward<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>>' requested here
 1929 |       std::copy_backward(__f, __m, __old_end);
      |            ^
/usr/local/clang+llvm-18.1.8-aarch64-linux-gnu/bin/../include/c++/v1/deque:1865:10: note: in instantiation of function template specialization 'std::deque<const llvm::BasicBlock *>::__insert_bidirectional<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>>' requested here
 1865 |   return __insert_bidirectional(__p, __f, __l, std::distance(__f, __l));
      |          ^
../llvm-project/llvm/include/llvm/ADT/STLExtras.h:2100:5: note: in instantiation of function template specialization 'std::deque<const llvm::BasicBlock *>::insert<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, 0>' requested here
 2100 |   C.insert(C.end(), adl_begin(R), adl_end(R));
      |     ^
../llvm-project/llvm/lib/Transforms/Instrumentation/PGOCtxProfFlattening.cpp:249:15: note: in instantiation of function template specialization 'llvm::append_range<std::deque<const llvm::BasicBlock *>, llvm::iterator_range<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>>>' requested here
  249 |         llvm::append_range(Worklist, successors(BB));
      |               ^
../llvm-project/llvm/include/llvm/ADT/APInt.h:2186:14: note: candidate function not viable: no known conversion from 'llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>' to 'APInt' for 1st argument
 2186 | inline APInt operator-(APInt a, uint64_t RHS) {
      |              ^         ~~~~~~~
../llvm-project/llvm/include/llvm/ADT/APInt.h:2175:14: note: candidate function not viable: no known conversion from 'llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>' to 'APInt' for 1st argument
 2175 | inline APInt operator-(APInt a, const APInt &b) {

```

</details>

https://github.com/llvm/llvm-project/pull/109183