[llvm] [ctx_prof] Fix `ProfileAnnotator::allTakenPathsExit` (PR #109183)

Wed Sep 18 21:10:41 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-5` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/6033

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
9.780 [4457/8/1433] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/SymbolSize.cpp.o
9.789 [4456/8/1434] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/TapiFile.cpp.o
9.801 [4455/8/1435] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/TapiUniversal.cpp.o
9.810 [4454/8/1436] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/MachOUniversalWriter.cpp.o
9.820 [4453/8/1437] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/WasmObjectFile.cpp.o
9.829 [4452/8/1438] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/WindowsMachineFlag.cpp.o
9.842 [4451/8/1439] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/WindowsResource.cpp.o
9.853 [4450/8/1440] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/XCOFFObjectFile.cpp.o
9.863 [4449/8/1441] Building CXX object lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/ArchiveEmitter.cpp.o
9.864 [4448/8/1442] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o
FAILED: lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /opt/homebrew/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Users/buildbot/buildbot-root/aarch64-darwin/build/lib/Transforms/Instrumentation -I/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/lib/Transforms/Instrumentation -I/Users/buildbot/buildbot-root/aarch64-darwin/build/include -I/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/include -isystem /opt/homebrew/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -O3 -DNDEBUG -std=c++17 -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o -MF lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o.d -o lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/PGOCtxProfFlattening.cpp.o -c /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/lib/Transforms/Instrumentation/PGOCtxProfFlattening.cpp
In file included from /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/lib/Transforms/Instrumentation/PGOCtxProfFlattening.cpp:21:
In file included from /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/include/llvm/Transforms/Instrumentation/PGOCtxProfFlattening.h:15:
In file included from /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/include/llvm/IR/PassManager.h:40:
In file included from /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/include/llvm/ADT/DenseMap.h:25:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/algorithm:1752:
/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/__algorithm/copy_backward.h:98:68: error: invalid operands to binary expression ('llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>' and 'long')
      auto __iter        = std::__copy_backward<_AlgPolicy>(__last - __size, __last, __local_last).second;
                                                            ~~~~~~ ^ ~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/__algorithm/copy_move_common.h:109:19: note: in instantiation of function template specialization 'std::__copy_backward_loop<std::_ClassicAlgPolicy>::operator()<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>, 0>' requested here
  auto __result = _Algorithm()(std::move(__range.first), std::move(__range.second), std::__unwrap_iter(__out_first));
                  ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/__algorithm/copy_move_common.h:133:15: note: in instantiation of function template specialization 'std::__unwrap_and_dispatch<std::__overload<std::__copy_backward_loop<std::_ClassicAlgPolicy>, std::__copy_backward_trivial>, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>, 0>' requested here
  return std::__unwrap_and_dispatch<_Algorithm>(std::move(__first), std::move(__last), std::move(__out_first));
              ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/__algorithm/copy_backward.h:122:15: note: in instantiation of function template specialization 'std::__dispatch_copy_or_move<std::_ClassicAlgPolicy, std::__copy_backward_loop<std::_ClassicAlgPolicy>, std::__copy_backward_trivial, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>>' requested here
  return std::__dispatch_copy_or_move<_AlgPolicy, __copy_backward_loop<_AlgPolicy>, __copy_backward_trivial>(
              ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/__algorithm/copy_backward.h:135:15: note: in instantiation of function template specialization 'std::__copy_backward<std::_ClassicAlgPolicy, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>>' requested here
  return std::__copy_backward<_ClassicAlgPolicy>(
              ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/deque:2186:20: note: in instantiation of function template specialization 'std::copy_backward<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>, std::__deque_iterator<const llvm::BasicBlock *, const llvm::BasicBlock **, const llvm::BasicBlock *&, const llvm::BasicBlock ***, long>>' requested here
            _VSTD::copy_backward(__f, __m, __old_end);
                   ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/deque:2112:10: note: in instantiation of function template specialization 'std::deque<const llvm::BasicBlock *>::__insert_bidirectional<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>>' requested here
  return __insert_bidirectional(__p, __f, __l, std::distance(__f, __l));
         ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/include/llvm/ADT/STLExtras.h:2100:5: note: in instantiation of function template specialization 'std::deque<const llvm::BasicBlock *>::insert<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>>' requested here
  C.insert(C.end(), adl_begin(R), adl_end(R));
    ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/lib/Transforms/Instrumentation/PGOCtxProfFlattening.cpp:249:15: note: in instantiation of function template specialization 'llvm::append_range<std::deque<const llvm::BasicBlock *>, llvm::iterator_range<llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>>>' requested here
        llvm::append_range(Worklist, successors(BB));
              ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/include/llvm/ADT/APInt.h:2186:14: note: candidate function not viable: no known conversion from 'llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>' to 'APInt' for 1st argument
inline APInt operator-(APInt a, uint64_t RHS) {
             ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/include/llvm/ADT/APInt.h:2175:14: note: candidate function not viable: no known conversion from 'llvm::SuccIterator<const llvm::Instruction, const llvm::BasicBlock>' to 'APInt' for 1st argument
inline APInt operator-(APInt a, const APInt &b) {

```

</details>

https://github.com/llvm/llvm-project/pull/109183