[lld] [LLD][COFF] Do another pass of resolveRemainingUndefines for undefined lazy symbols (PR #109082)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 05:31:32 PDT 2024


================
@@ -2601,7 +2601,9 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
     createECExportThunks();
 
   // Resolve remaining undefined symbols and warn about imported locals.
-  ctx.symtab.resolveRemainingUndefines();
+  while (ctx.symtab.resolveRemainingUndefines()) {
+    run();
+  }
----------------
mstorsjo wrote:

I think we stylistically tend to omit the braces for these kinds of single-line statements, see https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements.

https://github.com/llvm/llvm-project/pull/109082


More information about the llvm-commits mailing list