[lld] [LLD][COFF] Do another pass of resolveRemainingUndefines for undefined lazy symbols (PR #109082)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 05:31:32 PDT 2024


https://github.com/mstorsjo approved this pull request.

LGTM overall, thanks! Two minor nits, one inline, and the other about the PR description:

As LLVM uses the "merge and squash" method, the PR subject + description ends up as the commit message (although whoever merges it has a chance to touch it up), so it's good to edit it into the form that is wanted as the final commit message.

In this case, CCs and similar unfortunately is best to do in a separate comment after. It's good to include the issue reference though, but at this point it actually does fix the issue completely AFAIK, so that can be tweaked too.



https://github.com/llvm/llvm-project/pull/109082


More information about the llvm-commits mailing list