[compiler-rt] [compiler-rt] add check-cmp flag for nsan (PR #108707)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 14 08:49:37 PDT 2024
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/108707
Fixes #108435.
>From debd2826d523bdaf4fdf771c0f23765596e9da0e Mon Sep 17 00:00:00 2001
From: c8ef <c8ef at outlook.com>
Date: Sat, 14 Sep 2024 23:48:08 +0800
Subject: [PATCH] check cmp flag
---
compiler-rt/lib/nsan/nsan.cpp | 4 ++--
compiler-rt/lib/nsan/nsan_flags.inc | 5 ++++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/compiler-rt/lib/nsan/nsan.cpp b/compiler-rt/lib/nsan/nsan.cpp
index 4679bcd589eb45..1c06340549acae 100644
--- a/compiler-rt/lib/nsan/nsan.cpp
+++ b/compiler-rt/lib/nsan/nsan.cpp
@@ -25,7 +25,7 @@
// on the runtime configuration. The middle part indicates the type of
// the application value, the suffix (f,d,l) indicates the type of the
// shadow, and depends on the instrumentation configuration.
-// * __nsan_fcmp_fail_* emits a warning for an fcmp instruction whose
+// * __nsan_fcmp_fail_* emits a warning for a fcmp instruction whose
// corresponding shadow fcmp result differs.
//
//===----------------------------------------------------------------------===//
@@ -682,7 +682,7 @@ void fCmpFailFT(const FT Lhs, const FT Rhs, ShadowFT LhsShadow,
if (flags().enable_warning_stats)
nsan_stats->AddWarning(CheckTypeT::kFcmp, pc, bp, 0.0);
- if (flags().disable_warnings)
+ if (flags().disable_warnings || !flags().check_cmp)
return;
// FIXME: ideally we would print the shadow value as FP128. Right now because
diff --git a/compiler-rt/lib/nsan/nsan_flags.inc b/compiler-rt/lib/nsan/nsan_flags.inc
index 7c9e579d91fc33..760973295a8a50 100644
--- a/compiler-rt/lib/nsan/nsan_flags.inc
+++ b/compiler-rt/lib/nsan/nsan_flags.inc
@@ -49,4 +49,7 @@ NSAN_FLAG(bool, enable_loadtracking_stats, false,
NSAN_FLAG(bool, poison_in_free, true, "")
NSAN_FLAG(bool, print_stats_on_exit, false, "If true, print stats on exit.")
NSAN_FLAG(bool, check_nan, false,
- "If true, check the floating-point number is nan")
\ No newline at end of file
+ "If true, check the floating-point number is nan")
+NSAN_FLAG(bool, check_cmp, true,
+ "If true, emit a warning for a fcmp instruction whose "
+ "corresponding shadow fcmp result differs.")
More information about the llvm-commits
mailing list