[llvm] b9d85b1 - [CodeGen] Use DenseMap::operator[] (NFC) (#108489)

via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 10:04:37 PDT 2024


Author: Kazu Hirata
Date: 2024-09-13T10:04:33-07:00
New Revision: b9d85b1263efa8c4953f8cf10999ee165f32922e

URL: https://github.com/llvm/llvm-project/commit/b9d85b1263efa8c4953f8cf10999ee165f32922e
DIFF: https://github.com/llvm/llvm-project/commit/b9d85b1263efa8c4953f8cf10999ee165f32922e.diff

LOG: [CodeGen] Use DenseMap::operator[] (NFC) (#108489)

Once we modernize CopyInfo with default member initializations,

  Copies.insert({Unit, ...})

becomes equivalent to:

  Copies.try_emplace(Unit)

which we can simplify further down to Copies[Unit].

Added: 
    

Modified: 
    llvm/lib/CodeGen/MachineCopyPropagation.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/MachineCopyPropagation.cpp b/llvm/lib/CodeGen/MachineCopyPropagation.cpp
index fab36f4858e093..8bcc437cbfb865 100644
--- a/llvm/lib/CodeGen/MachineCopyPropagation.cpp
+++ b/llvm/lib/CodeGen/MachineCopyPropagation.cpp
@@ -108,9 +108,10 @@ static std::optional<DestSourcePair> isCopyInstr(const MachineInstr &MI,
 
 class CopyTracker {
   struct CopyInfo {
-    MachineInstr *MI, *LastSeenUseInCopy;
+    MachineInstr *MI = nullptr;
+    MachineInstr *LastSeenUseInCopy = nullptr;
     SmallVector<MCRegister, 4> DefRegs;
-    bool Avail;
+    bool Avail = false;
   };
 
   DenseMap<MCRegUnit, CopyInfo> Copies;
@@ -240,8 +241,7 @@ class CopyTracker {
     // Remember source that's copied to Def. Once it's clobbered, then
     // it's no longer available for copy propagation.
     for (MCRegUnit Unit : TRI.regunits(Src)) {
-      auto I = Copies.insert({Unit, {nullptr, nullptr, {}, false}});
-      auto &Copy = I.first->second;
+      auto &Copy = Copies[Unit];
       if (!is_contained(Copy.DefRegs, Def))
         Copy.DefRegs.push_back(Def);
       Copy.LastSeenUseInCopy = MI;


        


More information about the llvm-commits mailing list