[clang] [llvm] Prefer std::getenv to ::getenv (PR #108529)

Vassil Vassilev via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 05:57:40 PDT 2024


vgvassilev wrote:

> Are we sure this is going to do what we think?
> 
> https://github.com/llvm/llvm-project/blob/a41bb71f2216cef08ab04f1d730ae1701c145f3c/libcxx/include/cstdlib#L127
> 
> https://github.com/gcc-mirror/gcc/blob/494d3c3faaee0dbde696ea334f8e242ae85ae2b5/libstdc%2B%2B-v3/include/c_compatibility/stdlib.h#L65

I am not sure if I understand the code you pointed to. That's one of the reasons I did not want to expand that patch beyond clang and llvm.

https://github.com/llvm/llvm-project/pull/108529


More information about the llvm-commits mailing list