[llvm] [llvm-objcopy][ELF] Disable huge section offset (PR #97036)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 13 00:59:46 PDT 2024
https://github.com/jh7370 commented:
Per the LLVM PR guidelines, please don't force push to PR branches once they are being reviewed - there's zero reason to, and it makes it harder to see what's changed since the previous version of the PR. Simply add fixup commits and, if really needed, merge commits can be used to merge in changes in main into the PR branch.
Also, please don't mark comments as "resolved" where I've started the discussion - I use these to track whether I'm happy with work done to address the points and I can't do that if they've already been marked as resolved (see https://discourse.llvm.org/t/rfc-github-pr-resolve-conversation-button/73178 for more context).
> @jh7370 Thanks a lot for your feedback!
>
> In my opinion, the more teams that use LLVM tools instead of GNU tools for embedded systems, the higher the likelihood of this issue being triggered.
I don't disagree with this point, but as this option is off by default, it's unlikely most of these people will use this option.
https://github.com/llvm/llvm-project/pull/97036
More information about the llvm-commits
mailing list