[llvm] [CodeGen] Use DenseMap::operator[] (NFC) (PR #108489)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 12 22:48:25 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-regalloc
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
Once we modernize CopyInfo with default member initializations,
Copies.insert({Unit, ...})
becomes equivalent to:
Copies.try_emplace(Unit)
which we can simplify further down to Copies[Unit].
---
Full diff: https://github.com/llvm/llvm-project/pull/108489.diff
1 Files Affected:
- (modified) llvm/lib/CodeGen/MachineCopyPropagation.cpp (+4-4)
``````````diff
diff --git a/llvm/lib/CodeGen/MachineCopyPropagation.cpp b/llvm/lib/CodeGen/MachineCopyPropagation.cpp
index fab36f4858e093..8bcc437cbfb865 100644
--- a/llvm/lib/CodeGen/MachineCopyPropagation.cpp
+++ b/llvm/lib/CodeGen/MachineCopyPropagation.cpp
@@ -108,9 +108,10 @@ static std::optional<DestSourcePair> isCopyInstr(const MachineInstr &MI,
class CopyTracker {
struct CopyInfo {
- MachineInstr *MI, *LastSeenUseInCopy;
+ MachineInstr *MI = nullptr;
+ MachineInstr *LastSeenUseInCopy = nullptr;
SmallVector<MCRegister, 4> DefRegs;
- bool Avail;
+ bool Avail = false;
};
DenseMap<MCRegUnit, CopyInfo> Copies;
@@ -240,8 +241,7 @@ class CopyTracker {
// Remember source that's copied to Def. Once it's clobbered, then
// it's no longer available for copy propagation.
for (MCRegUnit Unit : TRI.regunits(Src)) {
- auto I = Copies.insert({Unit, {nullptr, nullptr, {}, false}});
- auto &Copy = I.first->second;
+ auto &Copy = Copies[Unit];
if (!is_contained(Copy.DefRegs, Def))
Copy.DefRegs.push_back(Def);
Copy.LastSeenUseInCopy = MI;
``````````
</details>
https://github.com/llvm/llvm-project/pull/108489
More information about the llvm-commits
mailing list