[llvm] [Offload] Introduce offload-tblgen and initial new API implementation (PR #108413)
Joseph Huber via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 12 09:43:13 PDT 2024
jhuber6 wrote:
> I agree that not seeing the generated headers is unfortunate. In Unified Runtime we check in the generated files (and have a CI job that fails if the generated headers don't match the output of re-running the generation). All things aside I think I'd prefer that approach, but I understand that's not how any other LLVM project works so it might be difficult to get traction there.
We could probably do something similar, it's not like we're above checking in random blobs. For example, we have some random PDFs sitting around in the documentation directories.
I think in general this needs a test as well, and a clarification since as it stands this is basically a "new" runtime since it exposes the plugins separate from the OpenMP interface (which I like). Also, I'm thinking about the many issues we have with shared libraries, i.e. if someone wants to do OpenMP / Direct API stuff at the same time. (However I don't know how useful a use-case this really is).
https://github.com/llvm/llvm-project/pull/108413
More information about the llvm-commits
mailing list