[llvm] [AMDGPU] Use std::optional in InstCombine of amdgcn_fmed3. NFC. (PR #108223)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 11 06:54:35 PDT 2024
jayfoad wrote:
> > Not sure what the real benefit is
>
> I find it much cleaner to return things via the return value of a function, instead of modifying one of its arguments.
I'd also be happy with returning `nullptr` on failure, instead of using `optional`.
https://github.com/llvm/llvm-project/pull/108223
More information about the llvm-commits
mailing list