[llvm] [CodeGen] Fix documentation for ISD::ATOMIC_STORE (PR #108126)

via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 17:56:53 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-selectiondag

Author: Peilin Ye (peilin-ye)

<details>
<summary>Changes</summary>

Update `ISDOpcodes.h` documentation according to commit ad9d13d53591 ("SelectionDAG: Swap operands of atomic_store") for less confusion.  This costed me a few hours :-)

---
Full diff: https://github.com/llvm/llvm-project/pull/108126.diff


1 Files Affected:

- (modified) llvm/include/llvm/CodeGen/ISDOpcodes.h (+1-1) 


``````````diff
diff --git a/llvm/include/llvm/CodeGen/ISDOpcodes.h b/llvm/include/llvm/CodeGen/ISDOpcodes.h
index 65514882343dbe..18ed60ebb124dc 100644
--- a/llvm/include/llvm/CodeGen/ISDOpcodes.h
+++ b/llvm/include/llvm/CodeGen/ISDOpcodes.h
@@ -1304,7 +1304,7 @@ enum NodeType {
   /// This corresponds to "load atomic" instruction.
   ATOMIC_LOAD,
 
-  /// OUTCHAIN = ATOMIC_STORE(INCHAIN, ptr, val)
+  /// OUTCHAIN = ATOMIC_STORE(INCHAIN, val, ptr)
   /// This corresponds to "store atomic" instruction.
   ATOMIC_STORE,
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/108126


More information about the llvm-commits mailing list