[llvm] [CodeGen] Fix documentation for ISD::ATOMIC_STORE (PR #108126)

Peilin Ye via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 17:56:06 PDT 2024


https://github.com/peilin-ye created https://github.com/llvm/llvm-project/pull/108126

Update `ISDOpcodes.h` documentation according to commit ad9d13d53591 ("SelectionDAG: Swap operands of atomic_store") for less confusion.  This costed me a few hours :-)

>From aecc61f9f0b7a27a4d24e00c332562dae67a52e7 Mon Sep 17 00:00:00 2001
From: Peilin Ye <yepeilin at google.com>
Date: Wed, 11 Sep 2024 00:12:02 +0000
Subject: [PATCH] [CodeGen] Fix documentation for ISD::ATOMIC_STORE

Update ISDOpcodes.h documentation according to commit ad9d13d53591
("SelectionDAG: Swap operands of atomic_store") for less confusion.
---
 llvm/include/llvm/CodeGen/ISDOpcodes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/include/llvm/CodeGen/ISDOpcodes.h b/llvm/include/llvm/CodeGen/ISDOpcodes.h
index 65514882343dbe..18ed60ebb124dc 100644
--- a/llvm/include/llvm/CodeGen/ISDOpcodes.h
+++ b/llvm/include/llvm/CodeGen/ISDOpcodes.h
@@ -1304,7 +1304,7 @@ enum NodeType {
   /// This corresponds to "load atomic" instruction.
   ATOMIC_LOAD,
 
-  /// OUTCHAIN = ATOMIC_STORE(INCHAIN, ptr, val)
+  /// OUTCHAIN = ATOMIC_STORE(INCHAIN, val, ptr)
   /// This corresponds to "store atomic" instruction.
   ATOMIC_STORE,
 



More information about the llvm-commits mailing list