[llvm] [mlir] [ADT] Make DenseMap/DenseSet more resilient agains OOM situations (PR #107251)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 14:59:17 PDT 2024


kazutakahirata wrote:

Is there any way you could split your patch into several smaller ones?

If you are going to work on pretty much all of `DenseMap`/`DenseSet`, you might want to post a PR just to clang-format the whole thing.  This should separate interesting changes and the rest.

After that, I would get small obvious changes out of the way.  For example, your `if constexpr (std::is_trivially_destructible_v<ValueT>)` change will probably receive a quick LGTM.

Thanks!


https://github.com/llvm/llvm-project/pull/107251


More information about the llvm-commits mailing list