[llvm] [GlobalIsel] Visit ICmp (PR #105991)

[Amara Emerson via llvm-commits]

Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/105991 at github.com>


aemerson wrote:

> That didn't answer my question!
> 
> The isKnownNonZero analysis is in Utils.cpp and test coverage is in combine-visit-icmp.mir and icmp2.ll. Combine.td shows that precisely two combines were added and only of them relies on known bits.

I hadn't even closely looked at that combine yet, but from what I can tell you're using KB a lot in that `matchCmpOfZero` combine. It's quite a lot of code don't you think?


https://github.com/llvm/llvm-project/pull/105991