[llvm] [GlobalIsel] Visit ICmp (PR #105991)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 10 09:03:48 PDT 2024
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/105991 at github.com>
https://github.com/nikic requested changes to this pull request.
This needs to be split up into separate PRs, where each only adds a single fold, and each fold is well justified.
This PR is particularly problematic because it adds lot of *expensive* combines based on things like KnownBits -- these are very much not harmless folds you can add "just because".
https://github.com/llvm/llvm-project/pull/105991
More information about the llvm-commits
mailing list