[llvm] [RISCV] Rematerialize vmv.v.x (PR #107993)
Brandon Wu via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 10 05:30:30 PDT 2024
4vtomat wrote:
> > Thanks for the patch, it looks pretty good! One thing that I'm thinking about is that can you also add a precommit test for remat.ll so that I can see the difference between the original one and rematerialized one.
>
> It should be precommitted in the PR itself, so you can see the diff if you go to files changed > changes from all commits.
Oh, I didn't notice it was already there, thanks!
>
> I'm not sure what the convention is nowadays after the move to GitHub. Is precommitting directly to main preferred?
I'm not sure either, but in my opinion it's good to keep the precommit test for people that are not familiar with this part of code such as me lol~
https://github.com/llvm/llvm-project/pull/107993
More information about the llvm-commits
mailing list